naudachu
6d01ead245
ISSUE_ROOT was the relative `tmp/issues`, so "the store" was whatever
directory the shell happened to be standing in. It is the --out default
in all eight scripts of both layers, which made one `cd` — and a `cd`
outlives the command that ran it — enough for readers to report an empty
store on a full one and for writers to quietly build a second store
beside the first. `issue_index.py` run from inside tmp/issues left
tmp/issues/tmp/issues/ behind and exited 0.
The anchor is issue.py's own __file__, not cwd. A script's location is a
fact about the installation; cwd is a fact about the last `cd`, and the
scripts are invoked by path from wherever the agent happens to be. From
there `store_root()` walks up to the nearest repo marker — `.git`
(exists(), not isdir(): a worktree's .git is a file) or AGENTS.md for a
copy taken out of git — and joins tmp/issues. Markers rather than a
fixed number of `..` hops, because the layout is not a promise. cwd is
tried only if the scripts are not inside a repository at all.
The function lives in the domain layer and skills/sync imports it, so
both layers agree by construction — the direction the layering rule
allows. skills/issue stays stdlib-only.
An explicit --out still wins and is used exactly as typed: a relative
--out stays relative to cwd, because that is what the operator asked
for. No new environment surface.
Two consequences the issue also asked for:
- Missing is no longer reported as empty. `store_error()` returns one
message for a path that is not there and another for a store with no
issues in it.
- Nothing conjures a store as a side effect of a write. save() and
issue_index.build() require it instead of os.makedirs'ing it; only
issue_new.py and pull.py create one, and both say so on stderr.
Establishes tests/ — plain stdlib unittest, no pytest, no dependencies.
The store tests build a throwaway repo in a TemporaryDirectory (a .git
marker, a copy of both script layers, fixture issues) and run the real
scripts inside it as subprocesses from five different working
directories; tmp/issues/ is never touched. Against the pre-fix scripts
15 of the 21 fail, reproducing the report exactly — five stray stores,
including tmp/issues/tmp/issues.
python3 -m unittest discover -s tests -v
Closes claude-skills/tea#15
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
73 lines
2.3 KiB
Python
73 lines
2.3 KiB
Python
#!/usr/bin/env python3
|
|
"""
|
|
issue_check.py — validate issues against the canonical format. Offline.
|
|
|
|
The same check the sync layer runs before it pushes anything, available on its
|
|
own so a local-only issue can be held to the format without a tracker being
|
|
involved. Errors mean malformed; warnings mean it deviates from its type's
|
|
template or its graph looks suspect.
|
|
|
|
issue_check.py every issue in the store
|
|
issue_check.py wire-sqlc one issue
|
|
issue_check.py --quiet exit code only (0 clean, 1 errors)
|
|
|
|
Format reference: ../references/format.md
|
|
"""
|
|
import argparse
|
|
import os
|
|
import sys
|
|
|
|
sys.path.insert(0, os.path.dirname(os.path.abspath(__file__)))
|
|
import issue # noqa: E402
|
|
|
|
|
|
def main():
|
|
ap = argparse.ArgumentParser(description="Validate local issues (offline)")
|
|
ap.add_argument("ids", nargs="*", help="ids to check (default: all)")
|
|
ap.add_argument("--quiet", action="store_true", help="exit code only")
|
|
ap.add_argument("--strict", action="store_true", help="treat warnings as errors")
|
|
ap.add_argument("--out", default=issue.ISSUE_ROOT,
|
|
help="store root (default: <repo>/tmp/issues)")
|
|
args = ap.parse_args()
|
|
|
|
problem = issue.store_error(args.out)
|
|
if problem:
|
|
sys.exit("issue_check.py: %s" % problem)
|
|
|
|
issues = issue.load_all(args.out)
|
|
ids = args.ids or sorted(issues)
|
|
for i in ids:
|
|
if i not in issues:
|
|
sys.exit("issue_check.py: no issue %r in %s" % (i, args.out))
|
|
|
|
known = set(issues)
|
|
bad = 0
|
|
for i in ids:
|
|
err, warn = issue.validate(issues[i], known_ids=known)
|
|
if args.strict:
|
|
err, warn = err + warn, []
|
|
if err:
|
|
bad += 1
|
|
if args.quiet:
|
|
continue
|
|
if not err and not warn:
|
|
print("ok %s" % i)
|
|
continue
|
|
for e in err:
|
|
print("ERROR %s: %s" % (i, e))
|
|
for w in warn:
|
|
print("warn %s: %s" % (i, w))
|
|
|
|
for c in issue.find_cycles(issue.graph(issues)):
|
|
bad += 1
|
|
if not args.quiet:
|
|
print("ERROR cycle: %s" % " -> ".join(c))
|
|
|
|
if not args.quiet:
|
|
print("%d issue(s) checked, %d with errors" % (len(ids), bad))
|
|
return 1 if bad else 0
|
|
|
|
|
|
if __name__ == "__main__":
|
|
sys.exit(main())
|