naudachu
6d01ead245
ISSUE_ROOT was the relative `tmp/issues`, so "the store" was whatever
directory the shell happened to be standing in. It is the --out default
in all eight scripts of both layers, which made one `cd` — and a `cd`
outlives the command that ran it — enough for readers to report an empty
store on a full one and for writers to quietly build a second store
beside the first. `issue_index.py` run from inside tmp/issues left
tmp/issues/tmp/issues/ behind and exited 0.
The anchor is issue.py's own __file__, not cwd. A script's location is a
fact about the installation; cwd is a fact about the last `cd`, and the
scripts are invoked by path from wherever the agent happens to be. From
there `store_root()` walks up to the nearest repo marker — `.git`
(exists(), not isdir(): a worktree's .git is a file) or AGENTS.md for a
copy taken out of git — and joins tmp/issues. Markers rather than a
fixed number of `..` hops, because the layout is not a promise. cwd is
tried only if the scripts are not inside a repository at all.
The function lives in the domain layer and skills/sync imports it, so
both layers agree by construction — the direction the layering rule
allows. skills/issue stays stdlib-only.
An explicit --out still wins and is used exactly as typed: a relative
--out stays relative to cwd, because that is what the operator asked
for. No new environment surface.
Two consequences the issue also asked for:
- Missing is no longer reported as empty. `store_error()` returns one
message for a path that is not there and another for a store with no
issues in it.
- Nothing conjures a store as a side effect of a write. save() and
issue_index.build() require it instead of os.makedirs'ing it; only
issue_new.py and pull.py create one, and both say so on stderr.
Establishes tests/ — plain stdlib unittest, no pytest, no dependencies.
The store tests build a throwaway repo in a TemporaryDirectory (a .git
marker, a copy of both script layers, fixture issues) and run the real
scripts inside it as subprocesses from five different working
directories; tmp/issues/ is never touched. Against the pre-fix scripts
15 of the 21 fail, reproducing the report exactly — five stray stores,
including tmp/issues/tmp/issues.
python3 -m unittest discover -s tests -v
Closes claude-skills/tea#15
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
100 lines
3.5 KiB
Python
100 lines
3.5 KiB
Python
#!/usr/bin/env python3
|
|
"""
|
|
issue_tree.py — draw the dependency graph of the local store. Offline.
|
|
|
|
Edges come from the `depends:` metadata, which is the authoritative edge list;
|
|
prose in the body is never walked. Because the graph is slugs all the way down,
|
|
this works identically for issues that were never pushed anywhere.
|
|
|
|
issue_tree.py every root (nothing depends on it)
|
|
issue_tree.py wire-sqlc-appclick one subtree
|
|
issue_tree.py --depth 2 --write
|
|
|
|
Downwards is what this draws (what an issue depends on). The other direction is
|
|
a grep, not a flag:
|
|
|
|
grep -ln 'depends:.*migrate-schema' tmp/issues/*.md
|
|
"""
|
|
import argparse
|
|
import os
|
|
import sys
|
|
|
|
sys.path.insert(0, os.path.dirname(os.path.abspath(__file__)))
|
|
import issue # noqa: E402
|
|
|
|
|
|
def label(id, issues, seen, edges):
|
|
iss = issues.get(id)
|
|
if not iss:
|
|
return "%s (not in the store)" % id
|
|
tail = " (see above)" if id in seen and edges.get(id) else ""
|
|
return "%s [%s] %s — %s %s.md%s" % (
|
|
id, iss.type or "-", iss.title, iss.state, id, tail)
|
|
|
|
|
|
def render(roots, issues, edges, depth):
|
|
lines, seen = [], set()
|
|
|
|
def walk(id, prefix, is_last, is_root, level):
|
|
connector = "" if is_root else ("└── " if is_last else "├── ")
|
|
lines.append(prefix + connector + label(id, issues, seen, edges))
|
|
if id in seen or level >= depth:
|
|
return
|
|
seen.add(id)
|
|
kids = edges.get(id) or []
|
|
child_prefix = prefix if is_root else prefix + (" " if is_last else "│ ")
|
|
for i, k in enumerate(kids):
|
|
walk(k, child_prefix, i == len(kids) - 1, False, level + 1)
|
|
|
|
for r in roots:
|
|
if r in seen:
|
|
continue # already drawn as somebody's child — one tree, not two
|
|
walk(r, "", True, True, 0)
|
|
lines.append("")
|
|
|
|
head = roots[0] if len(roots) == 1 else "%d root(s)" % len(roots)
|
|
out = "# Dependency tree — %s\n\n```\n%s```\n" % (head, "\n".join(lines))
|
|
cycles = issue.find_cycles(edges)
|
|
if cycles:
|
|
out += "\n## Cycles\n\n" + "\n".join("- %s" % " -> ".join(c) for c in cycles) + "\n"
|
|
return out
|
|
|
|
|
|
def main():
|
|
ap = argparse.ArgumentParser(description="Draw the local dependency graph (offline)")
|
|
ap.add_argument("ids", nargs="*", help="roots (default: issues nothing depends on)")
|
|
ap.add_argument("--depth", type=int, default=6, help="max depth (default: 6)")
|
|
ap.add_argument("--write", action="store_true",
|
|
help="also write tmp/issues/tree-<slug>.md")
|
|
ap.add_argument("--out", default=issue.ISSUE_ROOT,
|
|
help="store root (default: <repo>/tmp/issues)")
|
|
args = ap.parse_args()
|
|
|
|
problem = issue.store_error(args.out)
|
|
if problem:
|
|
sys.exit("issue_tree.py: %s" % problem)
|
|
|
|
issues = issue.load_all(args.out)
|
|
edges = issue.graph(issues)
|
|
|
|
roots = args.ids
|
|
for r in roots:
|
|
if r not in issues:
|
|
sys.exit("issue_tree.py: no issue %r in %s" % (r, args.out))
|
|
if not roots:
|
|
depended_on = {d for deps in edges.values() for d in deps}
|
|
roots = sorted(i for i in issues if i not in depended_on) or sorted(issues)
|
|
|
|
text = render(roots, issues, edges, args.depth)
|
|
sys.stdout.write(text)
|
|
if args.write:
|
|
slug = roots[0] if len(roots) == 1 else "all"
|
|
path = os.path.join(args.out, "tree-%s.md" % slug)
|
|
with open(path, "w") as f:
|
|
f.write(text)
|
|
print("written: %s" % path)
|
|
|
|
|
|
if __name__ == "__main__":
|
|
main()
|